fix(QTable): add stopPropagation for checkbox (#305)

altai-ui · Jun 20, 2022 · da85128 · da85128
1 parent 128b840
commit da85128
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/qComponents/QCheckbox/src/QCheckbox.vue b/src/qComponents/QCheckbox/src/QCheckbox.vue
@@ -98,7 +98,11 @@ export default defineComponent({
     /**
      * alias for update:modelValue
      */
-    'change'
+    'change',
+    /**
+     * triggers when click
+     */
+    'click'
   ],
 
   setup(props: QCheckboxProps, ctx): QCheckboxInstance {
@@ -141,7 +145,7 @@ export default defineComponent({
         : props.disabled || (qForm?.disabled.value ?? false)
     );
 
-    const handleCheckboxClick = (): void => {
+    const handleCheckboxClick = (event: Event): void => {
       if (isDisabled.value) return;
 
       const value = !isChecked.value;
@@ -162,6 +166,8 @@ export default defineComponent({
 
         qCheckboxGroup.update(Array.from(set));
       }
+
+      ctx.emit('click', event);
     };
 
     watch(

diff --git a/src/qComponents/QCheckbox/src/types.ts b/src/qComponents/QCheckbox/src/types.ts
@@ -17,6 +17,6 @@ export interface QCheckboxInstance {
   isLimitDisabled: ComputedRef<boolean>;
   isDisabled: ComputedRef<boolean>;
   nativeClick: () => void;
-  handleCheckboxClick: () => void;
+  handleCheckboxClick: (event: Event) => void;
   checkboxInput: Ref<Nullable<HTMLInputElement>>;
 }
diff --git a/src/qComponents/QTable/src/QTableCellCheckbox/QTableCellCheckbox.vue b/src/qComponents/QTable/src/QTableCellCheckbox/QTableCellCheckbox.vue
@@ -89,7 +89,8 @@ export default defineComponent({
         modelValue: props.checked,
         indeterminate: props.indeterminate,
         validateEvent: false,
-        onChange: handleCheckboxChange
+        onChange: handleCheckboxChange,
+        onClick: (event: Event) => event.stopPropagation()
       });
     });