Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QDatepicker] add mobile support #139

Merged
merged 17 commits into from
Sep 17, 2021
Merged

[QDatepicker] add mobile support #139

merged 17 commits into from
Sep 17, 2021

Conversation

cheesytim
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://60f57a28b66d4b16ef03c909--qui-max.netlify.app

@cheesytim cheesytim requested a review from ViZhe July 19, 2021 13:36
@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://60f58082d262937f09ea7889--qui-max.netlify.app

const dynamicClientWidth = ref<number>(document.body.clientWidth);

const isMobileView = computed<boolean>(
() => dynamicClientWidth.value < 768
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вероятно это нужно как-то иначе давать определять

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

src/qComponents/QDatePicker/src/QDatePicker.vue Outdated Show resolved Hide resolved
src/qComponents/QDatePicker/src/q-date-picker.scss Outdated Show resolved Hide resolved
src/qComponents/QDatePicker/src/q-date-picker.scss Outdated Show resolved Hide resolved
@@ -669,11 +701,26 @@ export default defineComponent({
}
);

watch(isMobileView, value => {
if (value) {
handleClose();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут он уже не перестаёт быть handle

@@ -240,7 +247,9 @@ export default defineComponent({
return;
}

elementToFocusAfterClosing = document.activeElement as HTMLElement;
if (!props.preventFocusAfterClosing) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это условие скорее должно быть выше и оборачивать вот это https://github.com/Qvant-lab/qui-max/pull/139/files#diff-cce4f8be016b6dfc8ffc5395929304bf2e6ce8d9d0dff86fb0815f3a91740421R244-R246

@cheesytim cheesytim requested a review from ViZhe July 21, 2021 16:01
@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://60f845812abbf300c1f35be8--qui-max.netlify.app

src/qComponents/QDatePicker/src/QDatePicker.vue Outdated Show resolved Hide resolved
src/qComponents/QDatePicker/src/QDatePicker.vue Outdated Show resolved Hide resolved
src/qComponents/QDatePicker/src/panel/q-picker-panel.scss Outdated Show resolved Hide resolved
src/qComponents/QDatePicker/src/q-date-picker.scss Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://60fef07228732b160ca202a0--qui-max.netlify.app

@cheesytim cheesytim requested a review from ViZhe July 26, 2021 17:28
@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://60fefe6a086ff427d4a2a236--qui-max.netlify.app

src/qComponents/hooks/index.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://6103ae7ae8288d1a52919471--qui-max.netlify.app

@cheesytim cheesytim requested a review from ViZhe July 30, 2021 07:56
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

🚀 Netlify deployed qui-max as draft

https://61111f4d842ddbbed55fc508--qui-max.netlify.app

@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://611cbbf985575db4679d4f9b--qui-max.netlify.app

@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://6140bfc43fe1c16263d4b96e--qui-max.netlify.app

@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://61435d9a0bbc841dc71a83e5--qui-max.netlify.app

@@ -89,7 +89,8 @@ interface QDatePickerInstance {
state: QDatePickerState;
root: Ref<Nullable<HTMLElement>>;
panel: Ref<UnwrappedInstance<DatePanelInstance>>;
reference: Ref<Nullable<UnwrappedInstance<QInputInstance> | HTMLElement>>;
reference: Ref<Nullable<UnwrappedInstance<QInputInstance>>>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnwrappedInstance уже содержит Nullable
изображение

@@ -105,8 +108,10 @@ interface QDatePickerInstance {
iconClass: ComputedRef<string>;
handleInputDateChange: () => void;
handleKeyUp: (e: KeyboardEvent) => void;
handleKeydown: (e: KeyboardEvent) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleKeyDown

@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://6143684458950c29df4af5dd--qui-max.netlify.app

@github-actions
Copy link
Contributor

🚀 Netlify deployed qui-max as draft

https://61436b2d74e72455a8419bcb--qui-max.netlify.app

@cheesytim cheesytim merged commit 5f8db55 into main Sep 17, 2021
@cheesytim cheesytim deleted the datepicker-mobile branch September 17, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants