fix(QButton): types #264
Merged
fix(QButton): types #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for qui-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for qui-max ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SeregaBB
approved these changes
Apr 6, 2022
ViZhe
reviewed
May 4, 2022
ViZhe
reviewed
May 5, 2022
ViZhe
reviewed
May 13, 2022
ViZhe
reviewed
May 13, 2022
ViZhe
reviewed
May 13, 2022
shamilfrontend
force-pushed
the
typing-q-button
branch
from
2f11b8f to
c61f850
Compare
ViZhe
approved these changes
May 16, 2022
cheesytim
reviewed
May 16, 2022
| theme: props.theme, | ||
| type: props.type, | ||
| size: props.size | ||
| const isLoading = computed<boolean>(() => Boolean(props.loading)); |
There was a problem hiding this comment.
в пропс loading можно прокинуть null т.к. пропс не является required: true
придется делать везде где loading нужен как boolean как то так Boolean(props.loading)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.