Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Firebase iOS SDK version from 10.24.0 to 10.25.0 #410

Merged
merged 3 commits into from
May 11, 2024
Merged

chore: Update Firebase iOS SDK version from 10.24.0 to 10.25.0 #410

merged 3 commits into from
May 11, 2024

Conversation

boywithdv
Copy link
Contributor

@boywithdv boywithdv commented May 10, 2024 •
edited
Loading

🔗 Related Issues

  • closes #0

🙌 What's Done

  • Fix the version listed in FirebaseSDKVersionTag.txt
  • Delete already existing IOS,macOS Podfile.lock.
  • Running the pod install command
  • Operation check on Simulator, macOS, and Android
  • Removed firebase-related specifications in melos.yaml (because of differences in dependencies)

✍️ What's Not Done

🖼️ Image Differences

📝 Additional Notes

Resolved issue where Simulator would not start if the version listed in FirebaseSDKVersion.txt was 10.24.0.

@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (58a0704) to head (91de7b0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a0704...91de7b0. Read the comment docs.

@boywithdv boywithdv marked this pull request as ready for review May 10, 2024 03:41
@boywithdv boywithdv requested a review from a team as a code owner May 10, 2024 03:41
@boywithdv boywithdv requested review from riscait and removed request for a team May 10, 2024 03:41
@boywithdv boywithdv changed the title firebase_coreのバージョンを10.24.0から10.25にする chore:firebase_core version from 10.24.0 to 10.25 May 10, 2024
@riscait riscait changed the title chore:firebase_core version from 10.24.0 to 10.25 chore: firebase_core version from 10.24.0 to 10.25 May 10, 2024
@riscait riscait changed the title chore: firebase_core version from 10.24.0 to 10.25 chore: Update Firebase iOS SDK version from 10.24.0 to 10.25 May 10, 2024
riscait
riscait approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Title changed to chore: Update Firebase iOS SDK version from 10.24.0 to 10.25 👌

@boywithdv boywithdv changed the title chore: Update Firebase iOS SDK version from 10.24.0 to 10.25 chore: Update Firebase iOS SDK version from 10.24.0 to 10.25.0 May 10, 2024
@riscait riscait merged commit 7793183 into main May 11, 2024
8 checks passed
@riscait riscait deleted the firebase_core_non_update branch May 11, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riscait riscait riscait approved these changes

Assignees

@boywithdv boywithdv

Labels
flutter_app ios macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boywithdv @riscait