Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-add tasks that have not been executed #487

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Aug 29, 2024

🙌 What's Done

  • It seems that the res of flavor was not copied to main because copySources was not executed.

I noticed in the error that ic_launcher does not exist in main.

✍️ What's Not Done

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@riscait riscait marked this pull request as ready for review August 29, 2024 01:47
@riscait riscait requested a review from a team as a code owner August 29, 2024 01:47
@riscait riscait requested review from k-nkmr and removed request for a team August 29, 2024 01:47
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (85342a9) to head (e293f79).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85342a9...e293f79. Read the comment docs.

Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait enabled auto-merge (squash) August 29, 2024 02:03
@riscait riscait merged commit 5a6310a into main Aug 29, 2024
8 checks passed
@riscait riscait deleted the re-add-tasks-for-build-gradle branch August 29, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants