Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Merge appbar and body files into page #488

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Aug 29, 2024

🙌 What's Done

  • Merge appbar and body files into page
  • Delete unused files

✍️ What's Not Done

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We created a more powerful chat_ui package in another project, so this one is unnecessary.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (bc5eb7e) to head (8824288).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5eb7e...8824288. Read the comment docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused page files.

@riscait riscait force-pushed the merge-appbar-and-body-files-into-page branch from d1df542 to 8824288 Compare August 29, 2024 01:54
@riscait riscait marked this pull request as ready for review August 29, 2024 01:54
@riscait riscait requested a review from a team as a code owner August 29, 2024 01:54
@riscait riscait requested review from naipaka and removed request for a team August 29, 2024 01:54
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait merged commit 42fa21f into main Aug 29, 2024
8 checks passed
@riscait riscait deleted the merge-appbar-and-body-files-into-page branch August 29, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants