Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add script for post-clone setup in iOS CI #489

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Sep 3, 2024

🔗 Related Issues

🙌 What's Done

  • Add script for post-clone setup in iOS CI

✍️ What's Not Done

  • Create workflow

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Please refer to the following for the introduction process!
https://zenn.dev/naipaka/scraps/807963171ec6d9

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (5a6310a) to head (77b5b9d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6310a...77b5b9d. Read the comment docs.

@@ -1785,10 +1785,10 @@ packages:
dependency: transitive
description:
name: vm_service
sha256: f652077d0bdf60abe4c1f6377448e8655008eef28f128bc023f7b5e8dfeb48fc
sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also committed it since it was updated with melos bs!

@naipaka naipaka marked this pull request as ready for review September 3, 2024 03:46
@naipaka naipaka requested a review from a team as a code owner September 3, 2024 03:46
@naipaka naipaka requested review from boywithdv and riscait and removed request for a team September 3, 2024 03:46
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naipaka naipaka merged commit bfb474a into main Sep 3, 2024
9 checks passed
@naipaka naipaka deleted the 484-setup-xcode-cloud branch September 3, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants