ci/cd: Add workflow for create new release tag #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naipaka
requested review from
k-nkmr and
riscait
and removed request for
a team
naipaka
force-pushed
the
484-setup-xcode-cloud-2
branch
from
755ae0f to
74eb8f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
=======================================
Coverage 23.75% 23.75%
=======================================
Files 13 13
Lines 160 160
=======================================
Hits 38 38
Misses 122 122 Continue to review full report in Codecov by Sentry.
|
naipaka
commented
Sep 3, 2024
| @@ -34,6 +37,6 @@ curl -sL https://firebase.tools | bash | |||
| dart pub global activate flutterfire_cli | |||
|
|
|||
| # Build the iOS app in release mode with no code signing. | |||
| flutter build ios --release --dart-define-from-file=dart_defines/prod.env --no-codesign | |||
| flutter build ios --release --dart-define-from-file=dart_defines/${flavor}.env --no-codesign | |||
There was a problem hiding this comment.
I apologize for the inconvenience after the review, but I modified the app to allow for building according to the environment by using environment variables!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
🙌 What's Done
✍️ What's Not Done
🖼️ Image Differences
🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
I modified the Xcode Cloud workflow to trigger on tag creation, so I added a workflow that automatically creates a tag when merging into the release branch!
Once this PR is merged, I'll proceed with verifying the operation of Xcode Cloud.
Reference: https://zenn.dev/naipaka/scraps/807963171ec6d9
Pre-launch Checklist