Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Build iOS with Xcode 16, Bump Firebase SDK to 11.0 #495

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Sep 22, 2024

🙌 What's Done

✍️ What's Not Done

  • Supports public_member_api_docs

🖼️ Image Differences

macOS iOS
image IMG_C1FDEFB59A40-1

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (5e4fdb2) to head (5afb169).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88115fd...5afb169. Read the comment docs.

@riscait riscait changed the title build: Update Firebase packages build: Build iOS with Xcode 16, Bump Firebase SDK to 11.0 Sep 22, 2024
@riscait riscait marked this pull request as ready for review September 22, 2024 14:31
@riscait riscait requested a review from a team as a code owner September 22, 2024 14:31
@riscait riscait requested review from boywithdv and removed request for a team September 22, 2024 14:31
Copy link
Contributor

@boywithdv boywithdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for upgrading the Firebase SDK and building for iOS with Xcode 16!🚀

@riscait riscait merged commit cb2ee24 into main Sep 24, 2024
8 checks passed
@riscait riscait deleted the upadte-firebase-packages branch September 24, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants