Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix building iOS with Xcode 16 #496

Closed
wants to merge 1 commit into from
Closed

Conversation

riscait
Copy link
Member

@riscait riscait commented Sep 22, 2024

πŸ”— Related Issues

  • closes #0

πŸ™Œ What's Done

✍️ What's Not Done

πŸ–ΌοΈ Image Differences

Before After
image image

🀼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

πŸ“ Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 23.75%. Comparing base (5e4fdb2) to head (5ffcaba).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 88115fd...5ffcaba. Read the comment docs.

@riscait
Copy link
Member Author

riscait commented Sep 22, 2024

Consolidated to #495.

@riscait riscait closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant