Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add absolute filepath support #30

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add absolute filepath support #30

merged 2 commits into from
Oct 29, 2024

Conversation

mayurikini
Copy link
Contributor

Issue: #29

Trimming "\" and "/" from filename.

altugbakan
altugbakan requested changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@altugbakan altugbakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% there, just something about tests

altugbakan
altugbakan approved these changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@altugbakan altugbakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@altugbakan altugbakan merged commit 89b00d3 into altugbakan:main Oct 29, 2024
2 checks passed
@altugbakan altugbakan mentioned this pull request Oct 29, 2024
Closed
@mayurikini
Copy link
Contributor Author

@altugbakan Could you please release it? Thanks.

@mayurikini mayurikini deleted the fix_absolute_path branch October 29, 2024 20:47
@altugbakan
Copy link
Owner

@mayurikini Released the new version. Thank you so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altugbakan altugbakan altugbakan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurikini @altugbakan