Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify STATIC in add_library #71

Open
dariomangoni opened this issue Apr 2, 2024 · 0 comments
Open

Specify STATIC in add_library #71

dariomangoni opened this issue Apr 2, 2024 · 0 comments

Comments

@dariomangoni
Copy link

In dependencies/ryu/CMakeLists.txt, by calling add_library without the STATIC option, the choice between STATIC or SHARED is left to the BUILD_SHARED_LIBS option, set anywhere else in the parent CMake files.

However, since the CMake is currently not working with SHARED (at least on Win), thus implicitly restricting the build to STATIC only, might be worth to explicitly ask for STATIC?

I might be missing something.

I proposed the change in the original repo as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant