Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does user need to have chrome installed or can it be generalized to any default browser? #1

Open
prabhakar267 opened this issue Jul 21, 2017 · 5 comments
Assignees

Comments

@prabhakar267
Copy link

prabhakar267 commented Jul 21, 2017

As per this link (https://docs.python.org/2/library/webbrowser.html), I don't think it's necessary to mention the browser.
webbrowser should open your default browser

@amanmj
Copy link
Owner

amanmj commented Jul 21, 2017

Yeah that was the problem on mac on specifying no browser, it should have opened the default browser, but was opening on firefox so had to force chrome.

@prabhakar267
Copy link
Author

@amanmj was there any problem in firefox getting opened?

@amanmj
Copy link
Owner

amanmj commented Jul 21, 2017

@prabhakar267 if a user opens http://localhost:5000/ in chrome and the next tab opens in firefox?
That won't be convenient

@prabhakar267
Copy link
Author

I think the browser can be detected in flask from User-agents (https://stackoverflow.com/questions/9878020/how-do-i-get-the-user-agent-with-flask)
Also, webbrowser must have some method of opening the current browser or something like that.

@amanmj
Copy link
Owner

amanmj commented Jul 21, 2017

Yeah will have to add snippet to detect browser as well OS and open the same browser through webbrowser

@amanmj amanmj self-assigned this Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants