-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of markup in addition to rich values in defaultTranslationValues #1181
Comments
Hmm, I see. Therefore the default values you provide for There's currently a discussion around whether
There hasn't been a decision around this yet, but your issue seems to add one more bullet to this list. For the time being, I'd suggest looking into the alternatives mentioned in #611 and use one of those patterns. Hope this helps! |
That's exactly right. Apologies, I didn't find that topic when searching earlier. For what it's worth, when going through the documentation for the first time (I just migrated my entire app from I personally wouldn't mind doing something like: However I also would definitely not like to see this move into a direction like the common |
Yep, I agree. The alternatives are more verbose, but I think overall the gain in explicitness and more compatibility / less surprises should be worth it.
Yep, also agree here. We're not going there 🙂 Thanks a lot for sharing your perspective! I'll close this issue for the time being in favor of #611, your point is noted there now. |
Is your feature request related to a problem? Please describe.
In my app I'm using both
t.rich
andt.markup
relatively often, and the majority of the tags in use are common ones like:strong
,br
,i
, etc. Forrich
translations, I'm utilizingdefaultTranslationValues
in my provider but I'd also like to specify the appropriate strings for the same tags except formarkup
support.Describe the solution you'd like
Potentially extending the config of
defaultTranslationValues
?Describe alternatives you've considered
Haven't come up with an idea yet.
The text was updated successfully, but these errors were encountered: