Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure blob adapter #1366

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

OisinHick
Copy link

This is a WIP adapter for Azure. It is largely working in regards to booting etc however some fine-tuning is needed to fix how it strobes for the existence of a blob on boot, however, this shouldn't take too long to fix. This request is submitted per @amark advice in the Gun Gitter chat so the community can work further on this. Huge thanks to him for all his help and guidance.

- Added the base file to build on
- Added comment explaining adapter development status
Copy link
Owner

@amark amark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w000000000000 this is awesome, you're a hero!!! Quick couple anti-crash if-not-using-azure changes tho please.

let containerClient;

const { Readable } = require('stream');
const { BlobServiceClient, StorageSharedKeyCredential } = require("@azure/storage-blob");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be moved to L17 also

@@ -15,6 +15,8 @@
require('./rfs');
require('./rs3');
require('./wire');
require('./azure')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct! Tho, until you have it 100% working let's keep it commented out in PRs/prod. If a dev doesn't have Azure optionally NPM installed we want to make sure nothing crashes/breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants