-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve changelog rules #981
Conversation
### Added | ||
- Load both the configurations defined in this module and the configurations defined in the module which use it as dependency. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the tool we use remove blank lines around titles and lists. So if we make this change we will have inconsistency in changelog. I opened an issue on the tool, let's wait for a response. Otherwise, we have to fork the tool and make the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked explicitly oscarotero/keep-a-changelog#28 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ndpnt is that blocking for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please “request changes” then? That will make advancement easier to track 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update tool that generate changelog before to avoid spacing inconsistencies.
I opened an issue on the GitHub action that generate changelog superfaceai/release-changelog-action#269 |
Github action updated. I tested that it properly fix the format on a fork here |
Through learning about writing our changelog in #979, @Ndpnt and I listed additional rules.