Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Restrict the value types of builtin functions. #369

Closed
MuhamedMagdi opened this issue Jul 30, 2024 · 1 comment · Fixed by #400
Closed

[Feature] Restrict the value types of builtin functions. #369

MuhamedMagdi opened this issue Jul 30, 2024 · 1 comment · Fixed by #400
Labels
compiler enhancement New feature or request

Comments

@MuhamedMagdi
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now the built in functions doesn't have any restriction regarding the type. so we can for example cd [path] or mv file null.

Describe the solution you'd like
Throws an error in compile time as it will always fails

Describe alternatives you've considered
should we restrict these values to only be of type Text?

Additional context
I can work in this issue if it's a valid solution.

@Ph0enixKM
Copy link
Member

Let's restrict them to Text. Maybe in the future we'll add some Path type. Let's keep it simple for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants