Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Runtime dependencies checker? #95

Closed
b1ek opened this issue May 24, 2024 · 4 comments
Closed

[Feature] Runtime dependencies checker? #95

b1ek opened this issue May 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@b1ek
Copy link
Member

b1ek commented May 24, 2024

Im pretty sure that amber depends on things like bc, sed and [[, and possibly other script-specific dependencies.

Wouldn't it make sense to add a checker in the start of the program to ensure that all of them are there? That would prevent A LOT of runtime errors, as well as ensure safety

@Ph0enixKM
Copy link
Member

True. This is fairly needed. The checks should be added by default but also we need to let developers disable adding them as well.

@github-project-automation github-project-automation bot moved this to 📋 Todo in Amber Project May 25, 2024
@Ph0enixKM Ph0enixKM changed the title Runtime dependencies checker? ✨ Runtime dependencies checker? May 25, 2024
@b1ek b1ek moved this from 📋 Todo to 🏃‍♂️ In Progress in Amber Project May 26, 2024
@b1ek b1ek self-assigned this May 26, 2024
@boushley
Copy link
Contributor

We should probably also only focus on the dependencies of the Amber runtime. Trying to extract and automatically detect script specific dependencies seems like a bigger problem.

@Ph0enixKM
Copy link
Member

This problem is currently being resolved by @b1ek as a separate project https://github.com/b1ek/bshchk.

@Ph0enixKM Ph0enixKM added this to the Amber 0.4.0-alpha milestone Jun 17, 2024
@Mte90 Mte90 added the enhancement New feature or request label Jun 24, 2024
@Ph0enixKM Ph0enixKM changed the title ✨ Runtime dependencies checker? [Feature] Runtime dependencies checker? Jul 7, 2024
@b1ek b1ek mentioned this issue Jul 31, 2024
@b1ek
Copy link
Member Author

b1ek commented Nov 9, 2024

implemented in #383

@b1ek b1ek closed this as completed Nov 9, 2024
@github-project-automation github-project-automation bot moved this from 🏃‍♂️ In Progress to 🏁 Done in Amber Project Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants