Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameter turbo instead or turbolinks #433

Closed
hjhart opened this issue Oct 24, 2023 · 3 comments
Closed

Use parameter turbo instead or turbolinks #433

hjhart opened this issue Oct 24, 2023 · 3 comments

Comments

@hjhart
Copy link
Contributor

hjhart commented Oct 24, 2023

Turbolinks is no longer being actively developed. I've converted all uses of turbolinks in my app to turbo in doing the upgrade except for one.

Would y'all be willing to accept either turbo: true or turbolinks: true to support that? I think we could be backwards compatible to support both for some time while people migrate.

I'd be happy to submit a PR to close this issue out – I simply want to ensure that it would be considered for review.

Thanks!

@grosser
Copy link
Collaborator

grosser commented Oct 24, 2023

👍 supporting both sounds good :)

@hjhart
Copy link
Contributor Author

hjhart commented Oct 24, 2023

#434 Here is the PR!

@grosser grosser closed this as completed Oct 24, 2023
@hjhart
Copy link
Contributor Author

hjhart commented Oct 24, 2023

Thanks for the quick release as well @grosser! This was released in version 5.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants