Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation on Python 3.9 #48

Closed
amotl opened this issue Jan 14, 2021 · 6 comments
Closed

Installation on Python 3.9 #48

amotl opened this issue Jan 14, 2021 · 6 comments

Comments

@amotl
Copy link
Contributor

amotl commented Jan 14, 2021

Hi Ivelin,

as outlined within #46, there are no binary wheels for PyAV on Python 3.9 yet, see [1]. @Odianosen25 observed the same within PyAV-Org/PyAV#697. So, we probably should add a friendly question at [2], asking whether building and uploading binary wheels for Python 3.9 to PyPI would be possible.

Otherwise, people installing peerjs-python will need the complete compiler toolchain plus appropriate header files of ffmpeg and friends on their machines which might not be appropriate for many occasions as the additional build cycle will a) waste resources and b) might take quite a while on lower-end machines like the RaspberryPi or even less powerful ARM-based SBCs.

With kind regards,
Andreas.

[1] https://pypi.org/project/av/#files
[2] https://github.com/PyAV-Org/PyAV/issues

EDIT: I just recognized there are no PyAV wheels for ARM on [1] yet, so please forget about my last comment. However, it might make sense to also ask for them as I discovered that ambianic-box is actually ARM-based, right?

I found that PyAV already uses pibuildwheel and adding building for ARM into the mix will be possible. PyTables/PyTables#823 has many interesting details about this topic.

@ivelin
Copy link
Contributor

ivelin commented Jan 14, 2021

Hi Andreas,

Thank you for investigating further.

Maybe I misunderstood #47 . I thought Ubuntu 20.4 resolves the ffmpeg binary wheel issue and there is no need to build ffmpeg from source if python 3.9 is running on Ubuntu 20.4 or above. Is that not the case?

Maybe we can clarify in the docs that peerjs-python requires Ubuntu 20.4 or later to run within Python 3.9 without building ffmpeg from source.

I completely support opening a friendly request with [2].

I apologize for not being able to dig deeper into this specific issue at the moment. Tackling a number of other immediate project issues.

Ivelin

@amotl
Copy link
Contributor Author

amotl commented Jan 14, 2021

Hi Ivelin,

Maybe I misunderstood #47. I thought Ubuntu 20.4 resolves the ffmpeg binary wheel issue and there is no need to build ffmpeg from source if python 3.9 is running on Ubuntu 20.4 or above. Is that not the case?

That's partly true. While ffmpeg does not have to be compiled, the PyAV binding still does. When binary wheels of PyAV for Python 3.9 are provided, this step will not be required on downstream machines.

Maybe we can clarify in the docs that peerjs-python requires Ubuntu 20.4 or later to run within Python 3.9.

That will make sense.

I completely support opening a friendly request with [2].

I've just created PyAV-Org/PyAV#734.

I apologize for not being able to dig deeper into this specific issue at the moment. Tackling a number of other immediate project issues.

Good luck!

With kind regards,
Andreas.

@ivelin
Copy link
Contributor

ivelin commented Feb 12, 2021

@amotl

Just following up on the status of this issue. Can we close it or there is something else specific we need to do on our end?

@amotl
Copy link
Contributor Author

amotl commented Feb 12, 2021

Hi Ivelin,

I see that the release of PyAV 8.0.3 [1], published on Jan 23, 2021, now offers binary wheels for Python 3.9. So, I believe closing this issue is fine.

With kind regards,
Andreas.

[1] https://pypi.org/project/av/#files

@amotl amotl closed this as completed Feb 12, 2021
@amotl
Copy link
Contributor Author

amotl commented Feb 12, 2021

Proof:

virtualenv .venv --python=python3.9
source .venv/bin/activate
pip install peerjs
[...]
Collecting av~=8.0.0
  Downloading av-8.0.3-cp39-cp39-macosx_10_9_x86_64.whl (21.5 MB)
[...]

@ivelin
Copy link
Contributor

ivelin commented Feb 13, 2021

Great. Thank you for verifying. I guess we can now remove the Python 3.9 note from the README doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants