Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential dependency conflicts between django-entity-emailer and django #68

Open
NeolithEra opened this issue May 11, 2020 · 2 comments

Comments

@NeolithEra
Copy link

Hi, as shown in the following full dependency graph of django-entity-emailer, django-entity-emailer requires django <3.0,>=2.0 , while the installed version of django (2.2.12)django-entity 4.2.0 requires django >=2.0.
According to Pip's “first found wins” installation strategy, django 2.2.12 is the actually installed version.
Although the first found package version django 2.2.12 just satisfies the later dependency constraint (django >=2.0), it will easily cause a build failure once the updated django-entity introduces a higher version of Django.
According to the release history of django-entity, it habitually upgrates Django in its recent releases. For instance, django-entity 3.0.0 upgrated Django’s constraint from >=1.11 to >=1.10, django-entity 3.1.1 upgrated Django’s constraint from >=1.10 to >=1.11, and django-entity 4.2.0 upgrated Django’s constraint from >=1.11 to >=2.0.

Dependency tree

django-entity-emailer  - 1.1.2
| +- ambition-django-uuidfield(install version:0.5.0 version range:>=0.5.0)
| | +- django(install version:3.0.5 version range:*)
| | | +- asgiref (install version: version range:=3.2)
| | | +- pytz(install version:2019.3 version range:*)
| | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | +- six(install version:1.14.0 version range:*)
| +- beautifulsoup4(install version:4.9.0 version range:>=4.3.2)
| | +- soupsieve(install version:2.0 version range:>1.2)
| | | +- backports.functools_lru_cache (install version: version range:*)
| +- django(install version:2.2.12 version range:>=2.0,<3.0)
| | +- pytz(install version:2019.3 version range:*)
| | +- sqlparse(install version:0.3.1 version range:*)
| +- django-db-mutex(install version:1.2.0 version range:>=1.2.0)
| | +- django(install version:3.0.5 version range:>=2.0)
| | | +- asgiref (install version: version range:=3.2)
| | | +- pytz(install version:2019.3 version range:*)
| | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| +- django-entity(install version:4.2.0 version range:>=4.2.0)
| | +- django(install version:2.2.12 version range:>=2.0)
| | | +- asgiref (install version: version range:=3.2)
| | | +- pytz(install version:2019.3 version range:*)
| | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | +- django-activatable-model(install version:1.2.1 version range:>=1.2.1)
| | | +- django(install version:2.2.12 version range:>=1.11)
| | | | +- asgiref (install version: version range:=3.2)
| | | | +- pytz(install version:2019.3 version range:*)
| | | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | | +- django-manager-utils(install version:1.4.0 version range:>=1.1.1)
| | | | +- django(install version:2.2.12 version range:>=1.10)
| | | | +- django-query-builder(install version: version range:>=1.1.0)
| | +- django-manager-utils(install version:1.4.0 version range:>=1.4.0)
| | | +- django(install version:2.2.12 version range:>=1.10)
| | | | +- asgiref (install version: version range:=3.2)
| | | | +- pytz(install version:2019.3 version range:*)
| | | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | | +- django-query-builder(install version: version range:>=1.1.0)
| | +- jsonfield(install version:3.1.0 version range:>=0.9.20)
| | | +- django (install version:2.2.12 version range:>=2.2)
| | | | +- asgiref (install version: version range:=3.2)
| | | | +- pytz(install version:2019.3 version range:*)
| | | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | +- python3-utils(install version:0.4.0 version range:>=0.3)
| | | +- six(install version:1.14.0 version range:>=1.8.0)
| | +- wrapt(install version:1.12.1 version range:>=1.10.5)
| +- django-entity-event(install version:1.2.0 version range:>=1.2.0)
| | +- cached-property(install version:1.5.1 version range:>=1.3.1)
| | +- django(install version:3.0.5 version range:>=2.0)
| | | +- asgiref (install version: version range:=3.2)
| | | +- pytz(install version:2019.3 version range:*)
| | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | +- django-entity(install version:4.2.0 version range:>=4.2.0)
| | | +- django(install version:2.2.12 version range:>=2.0)
| | | | +- asgiref (install version: version range:=3.2)
| | | | +- pytz(install version:2019.3 version range:*)
| | | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | | +- django-activatable-model(install version:1.2.1 version range:>=1.2.1)
| | | | +- django(install version:2.2.12 version range:>=1.11)
| | | | +- django-manager-utils(install version:1.4.0 version range:>=1.1.1)
| | | +- django-manager-utils(install version:1.4.0 version range:>=1.4.0)
| | | | +- django(install version:2.2.12 version range:>=1.10)
| | | | +- django-query-builder(install version: version range:>=1.1.0)
| | | +- jsonfield(install version:3.1.0 version range:>=0.9.20)
| | | | +- django (install version:2.2.12 version range:>=2.2)
| | | +- python3-utils(install version:0.4.0 version range:>=0.3)
| | | | +- six(install version:1.14.0 version range:>=1.8.0)
| | | +- wrapt(install version:1.12.1 version range:>=1.10.5)
| | +- jsonfield(install version:3.1.0 version range:>=0.9.20)
| | | +- django (install version:2.2.12 version range:>=2.2)
| | | | +- asgiref (install version: version range:=3.2)
| | | | +- pytz(install version:2019.3 version range:*)
| | | | +- sqlparse (install version:0.3.1 version range:>=0.2.2)
| | +- six(install version:1.14.0 version range:*)

Thanks for your help.
Best,
Neolith

@NeolithEra
Copy link
Author

NeolithEra commented May 11, 2020

Suggested Solution

  1. Loosen the version range of django to be >=2.0.
  2. Remove your direct dependency django, and use the django transitively introduced by django-entity.
  3. Change the version range of django-entity to be <=4.2.0.
    @swans-one Which solution do you prefer, 1 ,2 or 3?
    Please let me know your choice. May I pull a request to solve this issue?

@NeolithEra
Copy link
Author

@swans-one,Could you help me review this issue? Thx :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant