Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"hide node" from criteria table #497

Open
keyserj opened this issue Sep 9, 2024 · 0 comments
Open

"hide node" from criteria table #497

keyserj opened this issue Sep 9, 2024 · 0 comments
Labels
convenient makes the tool easier to use criteria table improves the criteria table enhancement New feature or request ok first issue Clear & narrow scope but tougher than "good first issue" QoL small change the improves the feel of using the tool

Comments

@keyserj
Copy link
Collaborator

keyserj commented Sep 9, 2024

Describe your issue

When I'm evaluating tradeoffs in the criteria table, sometimes I find that a criterion or solution were good to acknowledge, but I don't care about them right now, so I'd like to hide them. I can hide them by opening the table filters, adding all nodes to the respective solution or criteria filter, then removing the one I want to hide. But this is really cumbersome.

Also there's a "hide node" button when I right-click a node in the table, but it only hides the node in the diagram when I use it (so it appears to do nothing from the table view).

image

Solution you'd like

Make "hide node" (node context menu button) hide the node from the table if we're in the table view, and continue hiding the node in the diagram if we're in the diagram view. If we're right-clicking a node in the details pane, we probably shouldn't have the "hide" button at all.

image

Alternatives you've considered

No response

Additional context

No response

Technical ideas and questions

  • pass the WorkspaceContext into openContextMenu when right-clicking the node, so that the context menu options can behave differently based on if we're right-clicking on a node in the table, diagram, or details pane
  • the table filter currently shows all nodes if none are selected, so:
    • if it currently has no nodes selected, "hide node" will have to add all the nodes of the respective type (solution or criteria), then remove the one we're intending to hide
    • if it currently has nodes selected, "hide node" can just remove the one we're intending to hide
@keyserj keyserj added enhancement New feature or request ok first issue Clear & narrow scope but tougher than "good first issue" criteria table improves the criteria table QoL small change the improves the feel of using the tool convenient makes the tool easier to use labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convenient makes the tool easier to use criteria table improves the criteria table enhancement New feature or request ok first issue Clear & narrow scope but tougher than "good first issue" QoL small change the improves the feel of using the tool
Projects
Status: No status
Development

No branches or pull requests

1 participant