Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please tag a new release of ament_lint for foxy #434

Closed
esteve opened this issue Mar 6, 2023 · 2 comments
Closed

Please tag a new release of ament_lint for foxy #434

esteve opened this issue Mar 6, 2023 · 2 comments
Assignees
@quarkytale

Comments

@esteve
Copy link
Contributor

esteve commented Mar 6, 2023

Because of the changes in Pydocstyle 6.2.0 (addressed in #431), foxy's latest tagged version of ament_lint makes tests fail.

humble and rolling already have tagged releases that incorporate this change, but unfortunately foxy doesn't and it's causing projects that use https://github.com/ros-tooling/setup-ros to fail their CI jobs, due to the latter updating Pydocstyle to the latest version during the setup-ros phase. Thanks!
@esteve esteve mentioned this issue Mar 6, 2023
Merged
@quarkytale
Copy link

So this seems to be taken care of in 0.9.8 (see 0.9.7...0.9.8), closing it out!

@esteve
Copy link
Contributor Author

esteve commented May 11, 2023

@quarkytale Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quarkytale quarkytale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esteve @quarkytale