Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix performance regression in environment setup #106

Merged

Conversation

dirk-thomas
Copy link
Contributor

The trailing semicolon cleanup added in #104 was performed after every package. It only needs to happen once after all packages have finished.

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Dec 3, 2019
@dirk-thomas dirk-thomas self-assigned this Dec 3, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/fix-performance-regression-from-104 branch from c8b81cd to 0b7022b Compare December 3, 2019 17:00
@dirk-thomas dirk-thomas merged commit f045b35 into master Dec 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-performance-regression-from-104 branch December 3, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants