-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always consider .dsv files, even when no shell specific script exists #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy of colcon/colcon-core@3697164 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
sloretz
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI once the freeze is finished
@sloretz Friendly ping to follow up on this PR since Rolling freeze has already been lifted. |
@Mergifyio backport jazzy |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
…#147) Copy of colcon/colcon-core@3697164 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 01592eb)
ahcorde
pushed a commit
that referenced
this pull request
Jan 29, 2025
…#147) (#151) Copy of colcon/colcon-core@3697164 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 01592eb) Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #145
Copy of colcon/colcon-core@3697164