Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always consider .dsv files, even when no shell specific script exists #147

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 18, 2024

Copy of colcon/colcon-core@3697164

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI once the freeze is finished

@MichaelOrlov
Copy link

@sloretz Friendly ping to follow up on this PR since Rolling freeze has already been lifted.

@clalancette
Copy link
Contributor

clalancette commented Apr 26, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 01592eb into ament:rolling Apr 28, 2024
3 checks passed
@azeey azeey deleted the always-consider-dsv branch April 29, 2024 14:23
@azeey
Copy link
Contributor Author

azeey commented Jan 27, 2025

@Mergifyio backport jazzy

Copy link

mergify bot commented Jan 27, 2025

backport jazzy

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@ahcorde
Copy link

ahcorde commented Jan 27, 2025

https://github.com/Mergifyio backport jazzy

Copy link

mergify bot commented Jan 27, 2025

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 27, 2025
…#147)

Copy of colcon/colcon-core@3697164

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
(cherry picked from commit 01592eb)
ahcorde pushed a commit that referenced this pull request Jan 29, 2025
…#147) (#151)

Copy of colcon/colcon-core@3697164

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
(cherry picked from commit 01592eb)

Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.dsv files are not processed unless there is .sh file with the same base name
5 participants