remove all Python modules by the templates #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mikaelarguedas
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
lgtm, I leave it up to @nuclearsandwich to give final approval after confirming this works with ros_workspace
|
Test failures unrelated and addressed in ros2/system_tests#275 |
nuclearsandwich
approved these changes
Jun 6, 2018
There was a problem hiding this comment.
ros_workspace uses the template files from this project to provide the prefix-level scripts for binary packages. If there is any use of the python sections this PR would remove, that seems like it may indicate that we should be using catkin-pkg for those operations instead.
nuclearsandwich
added a commit
to nuclearsandwich/ament_package
that referenced
this pull request
Jun 13, 2018
The code which required pyparsing was dropped in ament#75.
nuclearsandwich
added a commit
that referenced
this pull request
Jun 13, 2018
The code which required pyparsing was dropped in #75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of ament/ament_cmake#137.
Since all usage of these modules have been changed to use
catkin_pkginstead they are being removed. The only thing left are the templates and the Python module to access them.