add warning/fallback for AMENT_CURRENT_PREFIX if relocated #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/ament-current-prefix-warning-and-fallback
branch
from
588e40e to
5275a7b
Compare
|
I have confirmed this fixes colcon/colcon-ros#67 |
|
Will this be able to make it into the Aug 27th Dashing patch release? |
No. The Dashing sync planned for that date does not include a patch release for ROS 2 core packages. |
Yes, I will backport the patch and do a bloom release of this package to be part of the sync. |
jacobperron
approved these changes
Aug 21, 2019
delete-merged-branch
bot
deleted the
dirk-thomas/ament-current-prefix-warning-and-fallback
branch
|
Since this commit is the only change compared to the I tagged a new version 0.7.1 and also fast-forwarded it to keep |
|
Thanks for this solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves colcon/colcon-ros#67.