Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we are closing the issue 8 and 25 #92

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

suvendu266
Copy link

please check the merge request.

Suvendu

@hechtprojects hechtprojects added this to the release v1.1.0 milestone Dec 11, 2024
@hechtprojects hechtprojects changed the base branch from main to develop December 11, 2024 15:25
Copy link
Member

@kay-ro kay-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes required.
please address the second round of comments as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Notes are for the users to read. Not internal development-comments. Could you please adapt the notes?
secondly, please add an appropriate comment to the sqiso function for the qmin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the qmin is not set to this default value in domain_length. please correct the comment. (it is expected that the q values are "correct" already)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please simplify the example?
for example:

  1. plot a linear function from 0 to 10.
  2. add one annotation arrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please modify the first example to a minimum working example.

  1. import amep
  2. as specified before, plot a linear function from 0 to 10.
  3. add one annotation arrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify the comment. qmin is not mentioned or defined anywhere beforehand.
Also mention what the distance between q values is and so on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRQ: Plot arrows for annotations. FRQ: Different standard value of qmin in amep.utils.domain_length.
3 participants