-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we are closing the issue 8 and 25 #92
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes required.
please address the second round of comments as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Notes are for the users to read. Not internal development-comments. Could you please adapt the notes?
secondly, please add an appropriate comment to the sqiso function for the qmin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the qmin is not set to this default value in domain_length. please correct the comment. (it is expected that the q values are "correct" already)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please simplify the example?
for example:
- plot a linear function from 0 to 10.
- add one annotation arrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please modify the first example to a minimum working example.
- import amep
- as specified before, plot a linear function from 0 to 10.
- add one annotation arrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify the comment. qmin is not mentioned or defined anywhere beforehand.
Also mention what the distance between q values is and so on...
please check the merge request.
Suvendu