Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(errorHandler): application errors would result in a 200 response #1243

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

@10xLaCroixDrinker 10xLaCroixDrinker commented Jan 19, 2024

Description

Set HTTP status code to 500 in application error handler

Motivation and Context

Application errors were causing HTTP 200 responses

How Has This Been Tested?

Triggered an application error caused by bug fixed in #1242 validated that HTTP status of error page was 200 before change and 500 after

Note: integration tests will fail until #1242 is merged

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Correct HTTP status of application errors

@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners January 19, 2024 23:29
Copy link
Contributor

github-actions bot commented Jan 19, 2024

Size Change: 0 B

Total Size: 712 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@Matthew-Mallimo
Copy link
Member

Does the browser still display the content delivered when its a 500 response?

@10xLaCroixDrinker
Copy link
Member Author

Does the browser still display the content delivered when its a 500 response?

Yes

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team January 22, 2024 22:33
@10xLaCroixDrinker 10xLaCroixDrinker enabled auto-merge (squash) January 23, 2024 14:51
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 26a7740 into main Jan 23, 2024
9 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the bugfix/application-error-500 branch January 23, 2024 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants