Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Objects to Maps #93

Open
AdamFoskit opened this issue Dec 21, 2020 · 3 comments
Open

Change Objects to Maps #93

AdamFoskit opened this issue Dec 21, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@AdamFoskit
Copy link

Using Map in place of Object could improve performance.
@github-actions
Copy link

Thanks for opening your first issue. Pull requests are always welcome!

@AdamFoskit
Copy link
Author

The benchmark has NUMBER_OF_SCENARIOS with MOCKS_PER_SCENARIO (attempting to mock a real-world scenario of a dev using parrot) and runs each function TEST_ITERATIONS number of times, takes the average from AVERAGE_ITERATIONS, then outputs some useful information about the test.

100 scenarios
10 mocks per scenario
image

5 scenarios
10 mocks per scenario
image

@ghost ghost added the enhancement New feature or request label Dec 22, 2020
@amexjake
Copy link
Contributor

amexjake commented Jul 8, 2021

Is this like across the code base? Or are there specific packages that could benefit from this in particular?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdamFoskit @amexjake