Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint duration in v3 #193

Closed
thmsobrmlr opened this issue Mar 19, 2019 · 3 comments · Fixed by #246
Closed

Lint duration in v3 #193

thmsobrmlr opened this issue Mar 19, 2019 · 3 comments · Fixed by #246

Comments

@thmsobrmlr
Copy link

When using v3 the lint duration increases significantly from 2min20sec to 5min:

# v3
$ yarn lint:js  279.63s user 9.65s system 96% cpu 5:00.14 total

# v2
$ yarn lint:js  145.92s user 7.04s system 109% cpu 2:20.31 total
@amilajack
Copy link
Owner

This is likely because we significantly increased the number of API's we check for compatibility. I'll look into ways to optimize this. Thanks for reporting this.

@TrevorBurnham
Copy link
Contributor

👋 Howdy! I've opened up two PRs that should cut linting time significantly: #245, #246

@Thomas88 If you get a chance, please try testing those branches against your project and let me know how much of a difference they make.

@saviomuc
Copy link

Hi @TrevorBurnham and @Thomas88.

Works for me. I tested the latest version and got these metrics 👏 :

2.7.0 > yarn lint:js 108.07s user 4.37s system 113% cpu 1:38.74 total
3.3.0-1 > yarn lint:js 111.01s user 4.75s system 113% cpu 1:41.76 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants