Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Laravel default language when using --remove-missing #46

Open
Stevemoretz opened this issue Dec 5, 2022 · 1 comment
Open

Keep Laravel default language when using --remove-missing #46

Stevemoretz opened this issue Dec 5, 2022 · 1 comment

Comments

@Stevemoretz
Copy link

Hi thanks for this package, it's pretty great.

Laravel comes with a bunch of messages used at core for validation, auth, pagination, and passwords, we can get a default set of languages using: https://github.com/Laravel-Lang/lang

if we use something like trans("validation.color") and then run

php artisan localize en --remove-missing

the validation.php file will be emptied, this probably can be solved using search.dirs in the config, any idea what the dirs should be? I don't think it would be as easy as that actually. for instance $this->translator->get was used at vendor/laravel/framework/src/Illuminate/Validation/Concerns/FormatsMessages.php

Anyways I think this should be supported by default maybe.

@Stevemoretz
Copy link
Author

attributes in validation.php needs to be handled somehow for the other languages, like sync keys that are defined, same for custom in validation.php those are important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant