Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Absolute paths in cache #201

Closed
amasad opened this issue Dec 21, 2017 · 3 comments
Closed

Absolute paths in cache #201

amasad opened this issue Dec 21, 2017 · 3 comments
Labels

Comments

@amasad
Copy link

amasad commented Dec 21, 2017

When deploying to, say heroku, you'll get a different temporary path on every deploy. And although you can carry over the .happypack cache we won't be able to use it because the paths are absolute.

Would you be open to changing that to make it relative to the root?

@amireh
Copy link
Owner

amireh commented Dec 22, 2017

Caching has been removed in v4 so this issue isn't applicable anymore. Is there a reason you can't use the latest version?

@amasad
Copy link
Author

amasad commented Dec 22, 2017

I think v4 is in beta? Also caching was removed? Why? That's the major reason we use happy pack, concurrency is nice to have for initial cold cache builds but that doesn't happen often

@amireh
Copy link
Owner

amireh commented Dec 24, 2017

v4 is out of beta since 8ef7852 (about 3 months ago.)

Re caching, see #154 (comment).

@amireh amireh added the invalid label Dec 24, 2017
@amasad amasad closed this as completed Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants