Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the Save function #45

Open
amiremohamadi opened this issue Oct 22, 2019 · 2 comments
Open

Optimize the Save function #45

amiremohamadi opened this issue Oct 22, 2019 · 2 comments
Labels
help wanted Extra attention is needed
Projects

Comments

@amiremohamadi
Copy link
Owner

DuckX is using zip library that only supports appending or writing new files. (unable to update a file inplace!)
So currently Save function works as follows:

  • make a new file
  • write any new files
  • copy the old files
  • delete old docx
  • rename new file to old file

And this process has a terrible performance on large files!

@amiremohamadi amiremohamadi added the help wanted Extra attention is needed label Oct 22, 2019
@CihanSari
Copy link
Contributor

Maybe use zlib and make use of this example / demo: https://github.com/skeeto/zlib-mutate-demo?

@amiremohamadi
Copy link
Owner Author

amiremohamadi commented Nov 8, 2019

Maybe use zlib and make use of this example / demo: https://github.com/skeeto/zlib-mutate-demo?

zlib is an awesome library and has great features. But as you may know I want to keep duckx as minimal as possible and zlib has a large codebase. So If there was no solution, we might switch to zlib or a similar library in the future.

@amiremohamadi amiremohamadi added this to To do in duckx board Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
duckx board
  
To do
Development

No branches or pull requests

2 participants