Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add complementary color to the text 'Fork on GitHub' with respect to its background #4

Open
amitoj-singh opened this issue Oct 10, 2020 · 3 comments
Assignees

Comments

@amitoj-singh
Copy link
Owner

amitoj-singh commented Oct 10, 2020

The ribbon at bottom right corner displaying 'Fork on GitHub' have its background color changing every second.
It can be even same as the color of the text which renders it invisible for that moment.
We want to fix this by applying complementary color to the text with respect to its Background.

Please go through the contributing guidelines, if you feel like helping🙂

@Apurva-Singh
Copy link

Hey @amitoj-singh I am interested in contributing to this issue, I will start working on this ASAP, will keep you updated.

@Apurva-Singh
Copy link

Hey @amitoj-singh I have tweaked the code of color_flipper.js. I researched if there was any pattern for hex-code for dark and bright colors, but alas, there is none. So what I did is, I made the color flipping semi-random. I chose around 110 dark and bright colors for the ribbon's background randomly from an array, and set the text color according to that. I have also tested it for all the colors, everything looks good. Please review the PR . ^_^

@amitoj-singh
Copy link
Owner Author

amitoj-singh commented Oct 13, 2020

Hey @amitoj-singh I have tweaked the code of color_flipper.js. I researched if there was any pattern for hex-code for dark and bright colors, but alas, there is none. So what I did is, I made the color flipping semi-random. I chose around 110 dark and bright colors for the ribbon's background randomly from an array, and set the text color according to that. I have also tested it for all the colors, everything looks good. Please review the PR . ^_^

Refer to Canva color wheel.
This will help you see a pattern in complementary colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants