Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/98 integration tests for confluence data reading #158

Merged

Conversation

zenzeii
Copy link
Contributor

@zenzeii zenzeii commented Jun 25, 2023

No description provided.

zenzeii and others added 6 commits June 25, 2023 15:26
Signed-off-by: Hafidz Arifin <hafidz.harifin@gmail.com>
Signed-off-by: Hafidz Arifin <hafidz.harifin@gmail.com>
Signed-off-by: Hafidz Arifin <hafidz.harifin@gmail.com>
Signed-off-by: Hafidz Arifin <hafidz.harifin@gmail.com>
Signed-off-by: Hafidz Arifin <hafidz.harifin@gmail.com>
@amela16
Copy link
Contributor

amela16 commented Jun 26, 2023

Maybe the feedback I have on this is for another issue. It is important to have the data from the Confluence in English. So we should think about testing this additionally.

@zenzeii
Copy link
Contributor Author

zenzeii commented Jun 26, 2023

@amela16 Thanks for the feedback! I think that would be part of the reading confluence data since I only do the integration test. Or do I misunderstood you? I see it too in supabase. Those German texts originated from the example pages in confluence. I thought it should be translated with the deepl_translator .py

@amela16
Copy link
Contributor

amela16 commented Jun 27, 2023

For me it feels also a but like am other issue. Its a bit like the step after reading, but very importantly the step before using the readed data. Maybe @SaraElBrak and @tkonheiser could take that into account. @Kadi-7 mentioned in his pull request that there might be some problems with different data structures, like tables. Do you take this in account? That might be related to point 2 of the user story from that Issue.

@zenzeii zenzeii merged commit 7716636 into main Jun 27, 2023
@tkonheiser tkonheiser deleted the feature/98_integration_tests_for_confluence_data_reading branch July 5, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants