All event_properties ignored if one key value is "None"

[dxprog]

Expected Behavior

When sending an event via amplitude.track with a dictionary of event properties where one value might be None, expect that the None value is either serialized to null or deleted.

Current Behavior

If any value within a dictionary is None, no event properties are sent. I suspect this is also an issue for user_properties and group_properties, though have not verified. Per the object validation method, a None value would cause the entire object to fail.

Possible Solution

Add None type to the list of valid values and let the object serialize it to null. This can then be filtered out appropriately in charts or addressed in code if it's an incorrect value.

Steps to Reproduce

okay_event = BaseEvent(
  event_type='test event', 
  user_id='12345',
  event_properties={'requiredProp': 'this is never null', 'optionalProp': 'this is sometimes null'},
)
okay_event.get_event_body()
# {'user_id': '12345', 'event_type': 'test event', 'event_properties': {'requiredProp': 'this is never null', 'optionalProp': 'this is sometimes null'}}

fail_event = BaseEvent(
  event_type='test event', 
  user_id='12345',
  event_properties={'requiredProp': 'this is never null', 'optionalProp': None},
)
fail_event.get_event_body()
# {'user_id': '12345', 'event_type': 'test event'}

Environment

• SDK Version: 1.1.3
• Python Version: 3.11
• OS Info: Ubuntu 20.04

[sheepsy90]

I experience the same issue. I also belief that this is incorrect behavior.

[liuyang1520]

Hi @dxprog , @sheepsy90 , thanks for reporting this!

It looks like a bug, and I am going to give it a try.

Thanks!

[liuyang1520]

The fix has been merged and released in https://pypi.org/project/amplitude-analytics/1.1.4/, PTAL! Closing this issue now. Thanks for supporting Amplitude!