Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add comments in isNewCampaign() #941

Merged
merged 2 commits into from
Dec 31, 2024
Merged

fix: add comments in isNewCampaign() #941

merged 2 commits into from
Dec 31, 2024

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Dec 31, 2024 •
edited by jira bot
Loading

Summary

AMP-119380
Add comments when deciding whether to fire an identify event to update campaign.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

izaaz
izaaz approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@izaaz izaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT comment

@Mercy811 Mercy811 merged commit a14a68c into main Dec 31, 2024
4 checks passed
@Mercy811 Mercy811 deleted the add-comments-isNewCampaign branch December 31, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaaz izaaz izaaz approved these changes

@chungdaniel chungdaniel Awaiting requested review from chungdaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mercy811 @izaaz