Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add safe access to loggerProvider in session replay plugin #949

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: add safe access to loggerProvider in session replay plugin #949

merged 2 commits into from
Feb 6, 2025

Conversation

liuyang1520
Copy link
Contributor

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

lewgordon-amplitude
lewgordon-amplitude approved these changes Feb 6, 2025
View reviewed changes
Copy link

@lewgordon-amplitude lewgordon-amplitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lewgordon-amplitude
Copy link

Thanks for this @liuyang1520 ! Never hesitate to request me as a reviewer directly on SDK prs.

@liuyang1520 liuyang1520 marked this pull request as ready for review February 6, 2025 18:22
@liuyang1520 liuyang1520 force-pushed the fix-session-replay-loggerProvider-undefined branch from 9589288 to 73f88f0 Compare February 6, 2025 18:23
@liuyang1520 liuyang1520 merged commit 54f16ef into v1.x Feb 6, 2025
4 checks passed
@liuyang1520 liuyang1520 deleted the fix-session-replay-loggerProvider-undefined branch February 6, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewgordon-amplitude lewgordon-amplitude lewgordon-amplitude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuyang1520 @lewgordon-amplitude