feat: add new evaluateConditions method to EvaluationEngine
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjhul
changed the title
evaluateCondition method to EvaluationEngineevaluateCondition method to EvaluationEngine
pjhul
commented
Oct 30, 2024
pjhul
force-pushed
the
pjhul/evaluate-conditions
branch
from
b42ecf8
to
302d24b
Compare
pjhul
changed the title
evaluateCondition method to EvaluationEngineevaluateConditions method to EvaluationEngine
bgiori
requested changes
Oct 31, 2024
bgiori
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes a new
evaluateConditionson theEvaluationEngineclass.This need arose while working on the assistance integration project, specifically with Page targeting. This method allows us to use the same conditions model as segments, without needing to include all the extra information like bucketing.
Checklist