Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Fixing any issues with rendering native blocks in AMP #1010

Closed
postphotos opened this issue Mar 9, 2018 · 6 comments
Closed
Assignees
Milestone

Comments

@postphotos
Copy link
Contributor

postphotos commented Mar 9, 2018

As a WordPress site running Gutenberg, my core/native blocks should be renderable as AMP-HTML compatible markup.

AC1: Any issues previously identified with core blocks from #845 should be fixed here.

@westonruter
Copy link
Member

See #902 (comment)

@kienstra
Copy link
Contributor

More Blocks Supported

Hi @miina,
Please see this comment on #845, if you haven't already. I marked more blocks as supported.

@miina
Copy link
Contributor

miina commented Mar 15, 2018

@westonruter Looks like as of now the only non-supported core blocks is the Categories with dropdown block. The issue there seems to be removing the script that's handling the option selection. For this specific case maybe a separate AMP_Block_Sanitizer for processing the comments wouldn't be necessary and we could just replace the render_callback of the block (similar as your Categories Widget solution) for the AMP page. Thoughts?

@postphotos
Copy link
Contributor Author

postphotos commented Mar 15, 2018

Hi @miina and @kienstra:
I've updated the issue here with a formal Story and Acceptance Criteria. When #845 concludes, let me know and I'll flesh out what's here based on your discovery. Thanks!

@postphotos
Copy link
Contributor Author

Oh also @miina pointed out that AC1 from #1008 may apply here. 👍

@kienstra
Copy link
Contributor

kienstra commented Mar 16, 2018

Results Of Discovery

Hi @postphotos,
Thanks for adding the Story and AC to this. The discovery from #845 is complete, though the results are on this wiki page. The only block with issues is Categories with a dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants