Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-https media #130

Closed
mjangda opened this issue Jan 26, 2016 · 5 comments
Closed

non-https media #130

mjangda opened this issue Jan 26, 2016 · 5 comments
Labels
Enhancement New feature or improvement of an existing one Validation

Comments

@mjangda
Copy link
Contributor

mjangda commented Jan 26, 2016

AMP requires that all content in amp-* components be https. We need to find a way to elegantly handle this. Should we just let it fail and have AMP raise an error? Or should we remove the element completely?

@mjangda mjangda added Enhancement New feature or improvement of an existing one Validation labels Jan 26, 2016
@bcampeau
Copy link
Contributor

I'm working on this right now for both non-https media and for non-https iframes in content. There is no way for us to be certain an https version exists, so I think the most elegant way is to strip it out.

I'm probably going to handle this in the theme, unless you'd like to see this updated in the plugin.

@coreymckrill
Copy link
Contributor

Related: #354

@coreymckrill coreymckrill mentioned this issue Sep 29, 2016
3 tasks
@westonruter
Copy link
Member

There is no way for us to be certain an https version exists, so I think the most elegant way is to strip it out.

We could do HEAD requests to both the HTTP and HTTPS versions to see if they return the same headers. If so, we could then remember that and automatically rewrite the HTTP URLs to use HTTPS for a given domain.

Otherwise, something we could consider is implement a WP-based proxy to pass-through HTTP resources as HTTPS. It would be a hack. Existing implementation: https://github.com/xwp/wp-customize-widgets-plus/blob/master/php/class-https-resource-proxy.php

@westonruter
Copy link
Member

Related: #2006, #2199.

@westonruter
Copy link
Member

Fallbacks for iframes and media elements have been implemented in #1913 and #1861. I think this is all we can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one Validation
Projects
None yet
Development

No branches or pull requests

4 participants