-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP files are being copied from src/
into assets/
#6947
Comments
I just pushed up WordPress/gutenberg#39171 that makes copying PHP files opt-in. Any feedback is appreciated! |
@ryanwelcher I'm not sure this is the same, as our JS files are in |
(I probably don't know what I'm talking about.) |
I may have commented on the wrong ticket but that PR is in reference to #6952 |
@ryanwelcher This is the correct issue. Thank you for fast-tracking WordPress/gutenberg#39171. Thanks to that, we can revert the non-reliable changes (in #6955). The build process should now work as before. |
@westonruter This is now ready for review: #6955. |
Files lists between 2.2.1 and 2.2.2-alpha shows that the expected files are added/removed: 22a23
> ./includes/sanitizers/class-amp-auto-lightbox-disable-sanitizer.php
28a30
> ./includes/sanitizers/class-amp-block-uniqid-sanitizer.php
58a61
> ./includes/ecosystem-data/analytics-vendors.php
90a94
> ./includes/embeds/class-amp-wordpress-embed-handler.php
1452,1499c1456,1502
< ./vendor/sabberworm/php-css-parser/lib
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/RuleSet
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/RuleSet/RuleSet.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/RuleSet/AtRuleSet.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/RuleSet/DeclarationBlock.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Settings.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/Document.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/CSSBlockList.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/KeyFrame.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/AtRuleBlockList.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/CSSList/CSSList.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parser.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Property
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Property/Import.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Property/Selector.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Property/Charset.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Property/AtRule.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Property/CSSNamespace.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Property/KeyframeSelector.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Comment
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Comment/Comment.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Comment/Commentable.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Renderable.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/Size.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/CalcFunction.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/RuleValueList.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/PrimitiveValue.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/CSSString.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/Value.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/URL.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/ValueList.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/Color.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/CSSFunction.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/LineName.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Value/CalcRuleValueList.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Rule
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Rule/Rule.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parsing
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parsing/UnexpectedTokenException.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parsing/ParserState.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parsing/SourceException.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parsing/UnexpectedEOFException.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/Parsing/OutputException.php
< ./vendor/sabberworm/php-css-parser/lib/Sabberworm/CSS/OutputFormat.php
---
> ./vendor/sabberworm/php-css-parser/src
> ./vendor/sabberworm/php-css-parser/src/RuleSet
> ./vendor/sabberworm/php-css-parser/src/RuleSet/RuleSet.php
> ./vendor/sabberworm/php-css-parser/src/RuleSet/AtRuleSet.php
> ./vendor/sabberworm/php-css-parser/src/RuleSet/DeclarationBlock.php
> ./vendor/sabberworm/php-css-parser/src/Settings.php
> ./vendor/sabberworm/php-css-parser/src/CSSList
> ./vendor/sabberworm/php-css-parser/src/CSSList/Document.php
> ./vendor/sabberworm/php-css-parser/src/CSSList/CSSBlockList.php
> ./vendor/sabberworm/php-css-parser/src/CSSList/KeyFrame.php
> ./vendor/sabberworm/php-css-parser/src/CSSList/AtRuleBlockList.php
> ./vendor/sabberworm/php-css-parser/src/CSSList/CSSList.php
> ./vendor/sabberworm/php-css-parser/src/Parser.php
> ./vendor/sabberworm/php-css-parser/src/Property
> ./vendor/sabberworm/php-css-parser/src/Property/Import.php
> ./vendor/sabberworm/php-css-parser/src/Property/Selector.php
> ./vendor/sabberworm/php-css-parser/src/Property/Charset.php
> ./vendor/sabberworm/php-css-parser/src/Property/AtRule.php
> ./vendor/sabberworm/php-css-parser/src/Property/CSSNamespace.php
> ./vendor/sabberworm/php-css-parser/src/Property/KeyframeSelector.php
> ./vendor/sabberworm/php-css-parser/src/Comment
> ./vendor/sabberworm/php-css-parser/src/Comment/Comment.php
> ./vendor/sabberworm/php-css-parser/src/Comment/Commentable.php
> ./vendor/sabberworm/php-css-parser/src/Renderable.php
> ./vendor/sabberworm/php-css-parser/src/Value
> ./vendor/sabberworm/php-css-parser/src/Value/Size.php
> ./vendor/sabberworm/php-css-parser/src/Value/CalcFunction.php
> ./vendor/sabberworm/php-css-parser/src/Value/RuleValueList.php
> ./vendor/sabberworm/php-css-parser/src/Value/PrimitiveValue.php
> ./vendor/sabberworm/php-css-parser/src/Value/CSSString.php
> ./vendor/sabberworm/php-css-parser/src/Value/Value.php
> ./vendor/sabberworm/php-css-parser/src/Value/URL.php
> ./vendor/sabberworm/php-css-parser/src/Value/ValueList.php
> ./vendor/sabberworm/php-css-parser/src/Value/Color.php
> ./vendor/sabberworm/php-css-parser/src/Value/CSSFunction.php
> ./vendor/sabberworm/php-css-parser/src/Value/LineName.php
> ./vendor/sabberworm/php-css-parser/src/Value/CalcRuleValueList.php
> ./vendor/sabberworm/php-css-parser/src/OutputFormatter.php
> ./vendor/sabberworm/php-css-parser/src/Rule
> ./vendor/sabberworm/php-css-parser/src/Rule/Rule.php
> ./vendor/sabberworm/php-css-parser/src/Parsing
> ./vendor/sabberworm/php-css-parser/src/Parsing/UnexpectedTokenException.php
> ./vendor/sabberworm/php-css-parser/src/Parsing/ParserState.php
> ./vendor/sabberworm/php-css-parser/src/Parsing/SourceException.php
> ./vendor/sabberworm/php-css-parser/src/Parsing/UnexpectedEOFException.php
> ./vendor/sabberworm/php-css-parser/src/Parsing/OutputException.php
> ./vendor/sabberworm/php-css-parser/src/OutputFormat.php
1502a1506
> ./src/BlockUniqidTransformer.php
1530d1533
< ./src/Admin/PluginActivationSiteScan.php
1537a1541
> ./src/Admin/AfterActivationSiteScan.php |
Bug Description
When running
npm run dev
I'm seeing in the console:Additionally, I'm seeing a bunch of PHP files from
src
being copied intoassets
:I believe this is a regression introduced by an upgrade to
@wordpress/scripts
.Expected Behaviour
Builds should work as they did before.
Screenshots
No response
PHP Version
No response
Plugin Version
2.2.2-alpha
AMP plugin template mode
Standard, Transitional, Reader
WordPress Version
No response
Site Health
No response
Gutenberg Version
No response
OS(s) Affected
No response
Browser(s) Affected
No response
Device(s) Affected
No response
Acceptance Criteria
No response
Implementation Brief
No response
QA Testing Instructions
No response
Demo
No response
Changelog Entry
No response
The text was updated successfully, but these errors were encountered: