Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-fill default configuration for top analytic vendors. #7019

Closed
dhaval-parekh opened this issue Apr 1, 2022 · 2 comments · Fixed by #7034
Closed

Pre-fill default configuration for top analytic vendors. #7019

dhaval-parekh opened this issue Apr 1, 2022 · 2 comments · Fixed by #7034
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Milestone
v2.3

Comments

@dhaval-parekh
Copy link
Collaborator

Feature Description

Currently, When users select "googleanalytics" or "gtag" in Analytics section ( in AMP Settings page) It pre-fills the default configuration.

image

A similar feature, we need to implement for other top vendors.

  1. Google Analytics
  2. Google Tag
  3. Google Ads
  4. Adobe Analytics
  5. Alexa Metrics
  6. Baidu analytics
  7. Facebook Pixel
  8. New Relic
  9. Nielsen
  10. Yandex Metrica

An example of default configuration can be found here.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response
@dhaval-parekh dhaval-parekh added the Enhancement New feature or improvement of an existing one label Apr 1, 2022
@dhaval-parekh dhaval-parekh self-assigned this Apr 1, 2022
@dhaval-parekh
Copy link
Collaborator Author

Related issue #6367

@westonruter westonruter added this to the v2.2.3 milestone Apr 1, 2022
@westonruter westonruter modified the milestones: v2.2.3, v2.2.4, 2.2.5 Apr 6, 2022
@dhaval-parekh dhaval-parekh mentioned this issue Apr 11, 2022
Merged
2 tasks
@maitreyie-chavan maitreyie-chavan modified the milestones: v2.2.5, v2.3 Apr 14, 2022
@pooja-muchandikar
Copy link

QA Passed ✅

Cross checked the 10 top vendors listed in issue description all are working fine except Google Ads. Google Ads default configuration is not getting pre-filled and this is expected behaviour as per the conversation with @dhaval-parekh

Screen.Recording.2022-06-06.at.5.19.39.PM.mov

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
None yet
Milestone
v2.3
Development

Successfully merging a pull request may close this issue.

Add default configuration for analytic vendors. ampproject/amp-wp
4 participants
@westonruter @dhaval-parekh @maitreyie-chavan @pooja-muchandikar