Fatal error (division by zero) in AMP_Core_Theme_Sanitizer::add_twentytwenty_custom_logo_fix()

[westonruter]

Bug Description

See support topic.

This code is not accounting for the case where the site logo image for some reason has a height of zero:

amp-wp/includes/sanitizers/class-amp-core-theme-sanitizer.php

Lines 878 to 879 in 4e54b03

	$desktop_width = $desktop_height * ( $width / $height );
	$mobile_width = $mobile_height * ( $width / $height );

This is also the case in this line:

amp-wp/includes/sanitizers/class-amp-core-theme-sanitizer.php

Line 590 in 4e54b03

$width = $height * ( $src[1] / $src[2] ); // Note that float values are allowed.

In both cases, we should make sure that when we cast the value to int that it is not zero, and if so, bail.

Expected Behaviour

No fatal error caused by division by zero should occur when site logo has an unexpected height of zero.

Screenshots

No response

PHP Version

No response

Plugin Version

2.3.0

AMP plugin template mode

Standard, Transitional

WordPress Version

No response

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

[milindmore22]

Just an Observation the user who reported this error is using an SVG image for logo

[pavanpatil1]

QA Passed ✅

Cross-checked the issue, Used the below snippet to verify the issue. The fix is working as expected.

if ( 'Twenty Twenty' === wp_get_theme()->get('Name') || 'Twenty Seventeen' === wp_get_theme()->get('Name') ) {
	add_filter(
		'get_custom_logo',
		static function () {
			return '<img src="https://avatars.githubusercontent.com/u/14114390?v=4" width="200" height="0">';
		}
	);
}

Before:

After fix: