Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMP_Core_Block_Handler to handle interactivity API enabled blocks #7647

Closed
thelovekesh opened this issue Oct 25, 2023 · 1 comment · Fixed by #7650
Closed

Update AMP_Core_Block_Handler to handle interactivity API enabled blocks #7647

thelovekesh opened this issue Oct 25, 2023 · 1 comment · Fixed by #7650
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone

Comments

@thelovekesh
Copy link
Collaborator

thelovekesh commented Oct 25, 2023

Bug Description

With WordPress/gutenberg#54297 the support for disabling interactivity API has been removed due to which the core/navigation block now is using interactivity API by default and is not working as expected.

Expected Behaviour

AMP_Core_Block_Handler should be updated to ampify interactivity API supported blocks and blocks should work as expected like they were before.

Screenshots

No response

PHP Version

No response

Plugin Version

2.4.2

AMP plugin template mode

Standard, Transitional

WordPress Version

No response

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@pavanpatil1
Copy link

QA Passed ✅

Cross-verified the issue and the navigation menu block is functioning fine. Verified the block with the WP 6.4 and with the 6.3 and Gutenberg latest version it is functioning fine. The Hamburger menu is working fine.

With WP v6.4 RC2.

Details
wp64.mp4

With WP v6.3 and latest Gutenberg plugin.

Details
with63.webm

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
@github-project-automation github-project-automation bot moved this to QA Passed in Ongoing Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants