Add PreloadHeroImage Optimizer transformer #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
added
Optimizer
WS:Perf
westonruter
requested changes
Oct 21, 2020
Comment on lines
+37
to
+39
| list($scheme, $host, $port, $user, $pass, $path, $query, $fragment) = array_values( | ||
| array_merge( | ||
| self::URL_DEFAULT_PARTS, |
There was a problem hiding this comment.
This feels a bit risky as it relies on the array keys being defined in the exact same order as the items in the list().
There was a problem hiding this comment.
Well, we control both, so why wouldn't they?
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
This was referenced Nov 3, 2020
|
Merging for importing into |
This was referenced Nov 3, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
PreloadHeroImagetransformer.This transformer optimizes image rendering times for hero images by adding preload and serverside-rendered
<img>tags when possible. Viable hero images are<amp-img>tags,<amp-video>tags with aposterattribute as well as<amp-iframe>and<amp-video-iframe>tags with aplaceholderattribute. The first viable image that is encountered is used by default, but this behavior can be overridden by adding thedata-heroattribute to a maximum of two images. The preloads only work work images that don't usesrcset, as that is not supported as a preload in most browsers. The serverside-rendered image will not be created for<amp-video>tags.Fixes #5055
Checklist