🌸 Cherry-pick request for #37314 into #37293

[mszylkowski]

Issue (P0 Bug)

#37314

Pull Request(s)

#37314

Release Tracker(s)

#37293

Channels

Beta / Experimental

Formats

Stories

Justification

When the story only has background audio specified in the amp-story (example) the audio icon doesn't show due to the amp-story not reporting to the store service that the story element has background audio.

This breaks existing AMP web pages in a significant way.

Verification Steps

On any story add in the amp-story tag the attribute background-audio="audio.mp3". The audio icon should be visible again.

Summary

Cleanup bug due to removing more code than what needed.

Impact

We don't have metrics on how many stories have background audio, but all stories with background-audio are impacted.

Action Items

Added unit test on test-amp-story to check the background audio is updated properly.

Notifications

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers

[gmajoulet]

Edit: previous comment was about a stable cherry pick.

Approved for beta/experimental.

[mszylkowski]

Yes, plan is to CP only to beta/experimental, I think all the extra labels got added automatically and I forgot to remove them.

[kristoferbaxter]

Approved. Thanks for adding tests!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.