Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified RuntimeError to NotFoundException in neo4j_proxy (metadata s… #1027

Closed
wants to merge 1 commit into from
Closed

Modified RuntimeError to NotFoundException in neo4j_proxy (metadata s… #1027

wants to merge 1 commit into from

Conversation

aparna-cimpress
Copy link
Contributor

@aparna-cimpress aparna-cimpress commented Apr 30, 2021 •
edited
Loading

Try block in _put_resource_description & put_column_description method in neo4j_proxy in metadata service throws RuntimeError when table or column doesn’t exist. I have changed it to throw NotFoundException with 404 status code.

@aparna-cimpress aparna-cimpress requested a review from a team as a code owner April 30, 2021 16:24
@aparna-cimpress
Copy link
Contributor Author

aparna-cimpress commented Apr 30, 2021 •
edited
Loading

Try block in _put_resource_description & put_column_description method in neo4j_proxy in metadata service throws RuntimeError when table or column doesn’t exist. I have changed it to throw NotFoundException with 404 status code.

@aparna-cimpress aparna-cimpress mentioned this pull request Apr 30, 2021
Closed
@dorianj
Copy link
Contributor

dorianj commented Apr 30, 2021

Hey, can you please submit this as a PR against the main branch, with the files changed directly (rather than across the sub-repos)? The Amundsen project moved to a monorepo.

@aparna-cimpress
Copy link
Contributor Author

Hey @dorianj I have opened another PR here
#1028

@dorianj dorianj closed this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aparna-cimpress @dorianj