chore: Add execution-required packages to setup.py #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wonong
requested review from
allisonsuarez,
bolkedebruin,
dikshathakur3119,
feng-tao,
jinhyukchang,
mgorsk1 and
verdan
as code owners
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Wonong
changed the title
feng-tao
approved these changes
Sep 25, 2020
|
@Wonong do we need to bump the common version for other repos to use the change? |
|
@feng-tao yes, i think it is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added marshmallow packages to setup.py since those packages are needed to use amundsencommon.
This change will allow another repos which are independent of marshmallow to use amundsencommon.
CheckList
Make sure you have checked all steps below to ensure a timely review.